On Fri, 13 Oct 2023 09:08:33 GMT, Daniel Fuchs <[email protected]> wrote:
>> Aleksei Efimov has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - test update: run IPv6-scoped address with wrong scope-id test case only
>> with at least 2 NI
>> - Moving snippets to class-level docs per Michael suggestion, associated
>> doc changes
>> - Daniel suggestions
>
> src/java.base/share/classes/java/net/Inet4Address.java line 190:
>
>> 188: * If string contains an {@linkplain
>> IPAddressUtil#validateNumericFormatV4(String, boolean)
>> 189: * ambiguous literal} - {@code IllegalArgumentException} is thrown
>> irrelevant to
>> 190: * {@code throwIAE} value.
>
> Suggestion:
>
> * {@code throwIAE} value.
> *
> * @apiNote
> * The given {@code addressLiteral} string is considered ambiguous if it
> cannot be parsed as
> * a valid IPv4 address literal using decimal notation, but could be
> * interpreted as an IPv4 address in some other representation (octal,
> hexadecimal, or mixed).
Thanks for the suggestions Daniel. They look reasonable to me, and improve the
readability. Taken them aboard in 4bd63f29386a515d63879412f80d958046e6c8c2.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15775#discussion_r1358126045