> Please find here a patch for a very rare intermittent failure observed in > CancelRequestTest. > > The fact that the number of pending requests hasn't been decremented leads me > to think that completable future returned by sendAsync (called from send) > hasn't been fully completed. That is, the dependent actions registered by > sendAsync have not been run within the timeout waiting for the number of > pending requests to reach 0. > > The fix is to call cf.get() again after calling cf.cancel(), and increase the > timeout waiting for cleanup in testPostInterrupt. > client.close() is also called at the end of each test method to reclaim > resources earlier
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Revert changes to HttpClientImpl.java - Merge branch 'master' into CancelRequest-8314136 - 8314136 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/15249/files - new: https://git.openjdk.org/jdk/pull/15249/files/43eb057d..2541292c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15249&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15249&range=00-01 Stats: 54751 lines in 1646 files changed: 34217 ins; 10810 del; 9724 mod Patch: https://git.openjdk.org/jdk/pull/15249.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15249/head:pull/15249 PR: https://git.openjdk.org/jdk/pull/15249
