On Wed, 9 Aug 2023 17:01:21 GMT, Michael McMahon <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Alan's suggestion - better wording
>>  - Alan's suggestion - consistency for "system configured" vs "system-wide"
>
> src/java.base/share/classes/java/net/InetAddress.java line 825:
> 
>> 823: 
>> 824:     /**
>> 825:      * Returns the fully qualified domain name for this address.
> 
> Maybe in the followup issue we could change "this address" to "the given 
> address" considering it's a static method. It's not part of the spec 
> regardless, so only a minor nit.

Hello Michael, that's a good catch. I've now pushed an update in this PR which 
fixes that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15134#discussion_r1289594769

Reply via email to