On Mon, 22 May 2023 15:58:01 GMT, Bernd <d...@openjdk.org> wrote: >> Jesse Glick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Leaving `FileURLConnection.is` non-null, and claiming `connected`, even >> after `closeInputStream` >> https://github.com/openjdk/jdk/pull/12871#discussion_r1199085883 > > src/java.base/share/classes/sun/net/www/protocol/jar/JarURLConnection.java > line 97: > >> 95: } >> 96: } finally { >> 97: if (jarFileURLConnection instanceof >> FileURLConnection fileURLConnection) { > > I Wonder if closing all urlconnection types or the ones with a special > interface instead of a specific type (which also introduces a dependency) > would be the better way? what about other connections with even more > temporary resources (like a temporary file copy?)
See discussion at https://github.com/openjdk/jdk/pull/12871#discussion_r1198932229. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12871#discussion_r1200725883
