On Wed, 29 Mar 2023 10:45:22 GMT, Daniel Jeliński <[email protected]> wrote:
> Please review this trivial fix for setting "Expect" header.
>
> The original code added a new header every time. As a result, when the
> request was retried, it was sent with two Expect headers.
> The new code replaces the original Expect header instead of adding a new one.
>
> Expect header allows only one value, "100-continue", so there's no risk of
> overwriting some other value.
>
> No new test. I added the bug ID to the test that was intermittently failing
> because of this issue. Existing tests continue to pass.
>
> Also fixed an unintentional passthrough in `switch` case that generated
> duplicate logs in tests.
LGTM
I wonder if the switch statement should be converted to use the newer switch
syntax. Up to you!
switch (x) {
case A -> { }
case B -> { }
}
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13224#pullrequestreview-1362848935
