On Wed, 29 Mar 2023 05:01:58 GMT, Jaikiran Pai <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into CustomRequestPublisher-8305095 >> - Removed unused imports >> - 8305095 > > test/jdk/java/net/httpclient/CustomRequestPublisher.java line 325: > >> 323: >> 324: https2TestServer = HttpTestServer.create(HTTP_2, sslContext); >> 325: https2TestServer.addHandler(new HttpTestEchoHandler(), >> "/https2/echo"); > > Hello Daniel, I don't see this `HttpTestEchoHandler` class anywhere in the > current test hierarchy. Is this a new file which was supposed to be included > in this PR? Never mind, I found it now. I had updated my IDE and for whatever reason its search feature wasn't finding this class. I just restarted the IDE and I see this class in `HttpServerAdapters`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13211#discussion_r1151398081
