> ### Description ### > Intermittent failures of this test are observed on frequent `HttpClient` test > runs. The test checks that the same connection is not used twice for two > seperate requests if an Idle Connection Timeout occurs by verifying that the > client-side port does not use the same port. It also verifies that when an > Idle Connection Timeout does not occur, the same connection is used by > verifying that the port used in both requests is the same. > > The issue here is that there is no guarantee that the ports used will not be > the same for when an Idle Connection Timeout occurs and so the test will/does > fail intermittently. > > ### Summary of Changes & Justification ### > Instead of comparing the post numbers of the connections used for each > request in all test cases, the connections themselves are now compared with > calls to `hashCode()` like so. The connection instances themselves are > accessed by using a customised `ExchangeSupplier` for the `Http2TestServer`.
Conor Cleary has updated the pull request incrementally with one additional commit since the last revision: 8301243: Simplified changes to server handlers ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12457/files - new: https://git.openjdk.org/jdk/pull/12457/files/99913369..f125c27c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12457&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12457&range=00-01 Stats: 20 lines in 1 file changed: 0 ins; 6 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/12457.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12457/head:pull/12457 PR: https://git.openjdk.org/jdk/pull/12457
