On Tue, 3 Jan 2023 18:26:36 GMT, Michael McMahon <micha...@openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Additional logging
>
> test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java
>  line 112:
> 
>> 110:         try (ServerSocketChannel ssc = ch) {
>> 111:             ssc.socket().bind(new 
>> InetSocketAddress(InetAddress.getLoopbackAddress(), 0));
>> 112:             SocketChannel sc1 = 
>> SocketChannel.open(ssc.getLocalAddress());
> 
> Could we add some logging/printlns here to indicate the protocol family of 
> `ch` or its local address, to aid in debugging if we ever have problems with 
> the test (eg on IPv6 only systems)?

Added; now it produces output like:

Using INET (IPv4) channel
Socket bound to /127.0.0.1:44179

-------------

PR: https://git.openjdk.org/jdk/pull/11638

Reply via email to