On Tue, 6 Dec 2022 14:04:17 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR proposes merging logic and optimising three classes that exist for >> aix, macos and windows. >> >> Optimisation will reduce byte code. Below is an example for one of the many >> methods optimised. >> >> Before: >> >> public void implCloseSelectableChannel() throws java.io.IOException; >> Code: >> 0: new #7 // class >> java/lang/UnsupportedOperationException >> 3: dup >> 4: ldc #11 // String SCTP not supported on >> this platform >> 6: invokespecial #13 // Method >> java/lang/UnsupportedOperationException."<init>":(Ljava/lang/String;)V >> 9: athrow >> >> >> After: >> >> public void implCloseSelectableChannel() throws java.io.IOException; >> Code: >> 0: invokestatic #16 // Method >> sun/nio/ch/sctp/UnsupportedUtil.sctpUnsupported:()Ljava/lang/UnsupportedOperationException; >> 3: athrow > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Remove UnsupportedUtil.java where not needed > - Merge branch 'master' into sctp-dedup > - Remove final declarations > - Move and refactor classes to reduce duplication > - Fix copyrignt and add sealed classes > - De-duplicate code in module jdk.sctp Please note that Skara does not update the list of labels when new files are added to a PR after it's creation. It is up to the committer and reviewer to be aware of such changes during the lifetime of a PR. In this case, it would have been appropriate to add the `build` label when the changes to the makefiles were introduced. ------------- PR: https://git.openjdk.org/jdk/pull/11436
