On Fri, 7 Oct 2022 08:25:05 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into url-early-parsing-8293590 >> - Merge branch 'master' into url-early-parsing-8293590 >> - 8293590 > > src/java.base/share/classes/sun/net/util/IPAddressUtil.java line 496: > >> 494: // is found. The caller is expected to use that message to >> 495: // throw an exception. >> 496: public static String checkUserInfo(String str) { > > I think IPAddressUtil was original introduced as a utility class to support > parsing of IP addresses and do text <--> byte[] conversion. It has grown into > checking the authority and userInfo components so I think is begging for a > rename or some refactoring. It's not this PR but I hope you see what I mean > on the naming/purpose of this class. Yes - I see. I have logged https://bugs.openjdk.org/browse/JDK-8294951 ------------- PR: https://git.openjdk.org/jdk/pull/10534