On Wed, 28 Sep 2022 16:15:42 GMT, Michael McMahon <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Close connections in finally block
>> - Fix copyright year
>
> src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java line 125:
>
>> 123: @SuppressWarnings("removal")
>> 124: public void put(final URL url, Object obj, HttpClient http) {
>> 125: HttpClient oldClient = null;
>
> Could you put a comment in there explaining what oldClient is exactly? Eg
> that it is a client that ends up being closed, either from the cache to make
> way for the newest entry or if the current client needs to be closed.
Added. Let me know if that's what you had in mind.
-------------
PR: https://git.openjdk.org/jdk/pull/10401
