On Thu, 1 Sep 2022 07:01:14 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this javadoc only change for >> `DatagramPacket#setLength()` method? This addresses >> https://bugs.openjdk.org/browse/JDK-7113208. >> >> I haven't create a CSR because the javadoc was already stating the correct >> behaviour in the `@throws` documentation as follows: >> >>> @throws IllegalArgumentException if the length is negative, >> * or if the length plus the offset is greater than the >> * length of the packet's data buffer. >> >> This commit merely fixes the main part of the javadoc. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > review comment - use Preconditions Thanks Jaikiran! LGTM! ------------- Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.org/jdk/pull/10037