On Wed, 12 Jan 2022 14:21:20 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Can I please get a review for this test only change which proposes to enable 
>> debug logs from the test that failed intermittently? This change addresses 
>> https://bugs.openjdk.java.net/browse/JDK-8278961.
>> 
>> The change passes the (test specific) `-d` option to enable logs from that 
>> test by default. While I was at it, I even added a few more debug logs 
>> hoping it might provide some hints if/when it fails next.
>> 
>> For reference, a (successful) run of this test will now print something like:
>> 
>> 
>> ----------System.out:(18/930)----------
>> running on OS that supports ICMP port unreachable
>> Testing with class java.net.DatagramSocket
>> tests will be run against destination address localhost/127.0.0.1 port 52682
>> Checking send to connected address ...
>> socket is locally bound to address /127.0.0.1 port 52681
>> received data from address /127.0.0.1 port 52681
>> received data from address /127.0.0.1 port 52681
>> received data from address /127.0.0.1 port 52681
>> received data from address /127.0.0.1 port 52681
>> received data from address /127.0.0.1 port 52681
>> Checking send to non-connected address ...
>> received data from address /127.0.0.1 port 52681
>> Checking send to invalid address ...
>> Got expected exception: java.net.PortUnreachableException
>> Got expected exception: java.net.PortUnreachableException
>> Got expected exception: java.net.PortUnreachableException
>> Got expected exception: java.net.PortUnreachableException
>> Got expected exception: java.net.PortUnreachableException
>
> test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java line 27:
> 
>> 25:  * @test
>> 26:  *
>> 27:  * @bug 4204320 8278961
> 
> Ah - can you remove 8278961 from the bug list before integrating?

`@bug` is supposed to be used to list the bugs that the test is verifying...

-------------

PR: https://git.openjdk.java.net/jdk/pull/6883

Reply via email to