Looks good to me, minor comment can you please use some int constant in place of (65527, 65507) ?. Vyom
On Fri, May 8, 2020 at 7:19 PM Patrick Concannon < patrick.concan...@oracle.com> wrote: > Hi, > > Could someone please review my fix for JDK-8242885 > 'PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams > on macOS with sizes between 65508-65527 bytes'? > > This fix changes the current max size for IPv6 datagrams on macOS from > it's current size of 65507, which is the IPv4 limit, to65527, the actual > limit for IPv6 on macOS. This will get around the issue of not being > able to send datagrams with sizes between65508-65527 bytes. > > bug: https://bugs.openjdk.java.net/browse/JDK-8242885 > webrev: http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.00/ > > > Kind regards, > > Patrick > > -- Thanks, Vyom