Hi Patrick, Thanks for testing, Alan, Daniel can i get the final review comment from you both ?.
Thanks, Vyom On Wed, Jul 8, 2020 at 8:17 PM Patrick Concannon < patrick.concan...@oracle.com> wrote: > Hi, > > No problem. > > I ran our tests against your latest patch, and everything passed. > > Thanks Vyom. > > Kind regards, > Patrick > > On 8 Jul 2020, at 06:49, Vyom Tiwari <vyomm...@gmail.com> wrote: > > Hi Patrick, > Thanks for testing, please find the latest webrev( > http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html). I > fixed the windows build issue. > Thanks, > Vyom > > On Tue, Jul 7, 2020 at 11:49 PM Patrick Concannon < > patrick.concan...@oracle.com> wrote: > >> Hi Vyom, >> >> I imported your latest patch and ran it on our test system, and I noticed >> the following error on Windows: >> >> [2020-07-07T11:09:20,621Z] >> T:\workspace\open\test\jdk\java\net\Socket\libNativeThread.c(54) : error >> C2220: the following warning is treated as an error >> [2020-07-07T11:09:20,621Z] >> T:\workspace\open\test\jdk\java\net\Socket\libNativeThread.c(54) : warning >> C4716: 'Java_NativeThread_signal': must return a value >> >> Kind regards, >> Patrick >> >> On 7 Jul 2020, at 04:14, Vyom Tiwari <vyomm...@gmail.com> wrote: >> >> Hi All, >> >> Please find the updated webrev( >> http://cr.openjdk.java.net/~vtewari/8237858/webrev0.9/index.html). I >> leave the idea of using the PoolCleaner. >> >> Thanks, >> Vyom >> >> On Sat, Jul 4, 2020 at 9:08 PM Martin Buchholz <marti...@google.com> >> wrote: >> >>> Right. It would be a project to create a jtreg test utility inspired >>> by PoolCleaner and use it in many tests. >>> >>> On Sat, Jul 4, 2020 at 8:24 AM Vyom Tiwari <vyomm...@gmail.com> wrote: >>> > >>> > Hi Martin >>> > Thanks for the review, I will try to address your review comment. >>> > >>> > I wanted to write a simple test case for this issue but it is getting >>> more complex. >>> > >>> > Thanks, >>> > Vyom >>> > >>> > On Sat, Jul 4, 2020 at 8:14 PM Martin Buchholz <marti...@google.com> >>> wrote: >>> >> >>> >> On Fri, Jul 3, 2020 at 11:12 PM Alan Bateman <alan.bate...@oracle.com> >>> wrote: >>> >> >>> >> > - "service" isn't a great name for the Executor. Also you can make >>> use >>> >> > of try-finally, e.g. >>> >> > ExecutorService executor = Executors.newFixedThreadPool(1); >>> >> > try { ... } finally { executor.shutdown(); } >>> >> >>> >> If you want to do this structured-concurrency-style, you should wait >>> >> for all the threads you started to complete (they might block!). >>> >> shutdown is not enough - you also want awaitTermination. >>> >> >>> >> We have a PoolCleaner utility in test/jdk/java/util/concurrent/tck/ to >>> >> help do this. >>> >> >>> >> try (PoolCleaner cleaner = cleaner(p)) { >>> > >>> > >>> > >>> > -- >>> > Thanks, >>> > Vyom >>> >> >> >> -- >> Thanks, >> Vyom >> >> >> > > -- > Thanks, > Vyom > > > -- Thanks, Vyom
