On 16/04/2020 14:39, Patrick Concannon wrote:
I've added the new testcases as requested, and you can find them in
the new webrev below.
http://cr.openjdk.java.net/~pconcannon/8237890/webrevs/webrev.02/
Looks good. A minor nit is that testGetters should probably be
testGetDefaults. I could imagine adding further tests in the future (no
need for a new webrev if you take up this suggestion).
I see Marks' comment about other javadoc. I agree that the
DatagramPacket javadoc could do some cleanup as there is inconsistent
wording used (some of it dates back to early JDK releases). Something
for another issue and probably low priority. The javadoc in your patch
is good.
-Alan
