Thanks Patrick.

Looks good me.

best regards,

-- daniel

On 16/04/2020 14:39, Patrick Concannon wrote:
Hi Chris,

Thanks for that.

I've added the new testcases as requested, and you can find them in the new webrev below.

http://cr.openjdk.java.net/~pconcannon/8237890/webrevs/webrev.02/


Kind regards,

Patrick

On 15/04/2020 16:54, Chris Hegarty wrote:
On 15 Apr 2020, at 16:40, Patrick Concannon<patrick.concan...@oracle.com>  
wrote:

...

webrev:http://cr.openjdk.java.net/~pconcannon/8237890/webrevs/webrev.01/

I added myself as reviewer on the CSR.

The changes mainly look good. Can you please add, or amend an existing, test 
for the newly specified default address and port values.

-Chris.


Reply via email to