Hi Alan,
On 27/01/2020 19:30, Alan Bateman wrote:
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8237896/webrev.00/
The API note for the class description looks good.
I'm less sure about the API notes added ot the joinGroup method because
you can't get a MulticastChannel from a MulticastSocket (getChannel
retruns null for starters). Maybe it should be just a @see instead?
I'm not sure I understand why obtaining a MulticastChannel from
a DatagramSocket is important. Maybe the wording needs to be
clarified?
http://cr.openjdk.java.net/~dfuchs/webrev_8237896/webrev.01
+ * @apiNote A better alternative to join multicast groups is provided
+ * by the {@code join} methods defined in the {@link
MulticastChannel}
+ * interface implemented by {@link DatagramChannel}.
+ * Condider using {@code DatagramChannel} instead of
+ * {@code MulticastSocket}
+ *
best regards,
-- daniel
