Hi Vyom,
Thanks for your feedback.
That's a good suggestion, and I've incorporated it into the webrev below.
http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.02/
Kind regards,
Patrick
On 14/11/2019 07:22, Vyom Tewari26 wrote:
Hi Patric,
Change looks ok to me, one minor bit i will suggest you to use
"List.of()" in place of"new ArrayList<>();".
Thanks,
Vyom
----- Original message -----
From: Patrick Concannon <patrick.concan...@oracle.com>
Sent by: "net-dev" <net-dev-boun...@openjdk.java.net>
To: Alan Bateman <alan.bate...@oracle.com>, OpenJDK Network Dev
list <net-dev@openjdk.java.net>
Cc:
Subject: [EXTERNAL] Re: RFR[8233860]:
java/net/SocketOption/AfterClose.java test incorrectly handles
IP_MULTICAST_IF
Date: Wed, Nov 13, 2019 11:13 PM
Hi Alan,
Thanks for your feedback.
My mistake. I've changed that now in the webrev below.
http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.01/
Kind regards,
Patrick
On 13/11/2019 16:53, Alan Bateman wrote:
On 13/11/2019 16:12, Patrick Concannon wrote:
Hi,
Could someone please review my fix for issue JDK-8233860
'java/net/SocketOption/AfterClose.java test incorrectly handles
IP_MULTICAST_IF' ?
The test, AfterClose.java, makes a call to setOption() after a
socket has been closed to verify that a SocketException is
thrown correctly. However, the test uses an invalid value
(boolean) for the IP_MULTICAST_IF option invalidating the test.
This fix corrects this error, and passes valid input for the
IP_MULTICAST_IF option (i.e. a NetworkInterface) ensuring that
the test behaves as expected.
bug: https://bugs.openjdk.java.net/browse/JDK-8233860
webrev:
http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.00/
<http://cr.openjdk.java.net/~pconcannon/8233989/webrevs/webrev.00/>
Looks okay although I assume supportsMulticast should be catching
SocketException rather that Throwable.
-Alan
