Daniel,
> On 26 Jun 2019, at 16:30, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
>
> Hi,
>
> Please find below a patch for:
>
> 8226514: Replace wildcard address with loopback or local host in
> tests - part 17
> https://bugs.openjdk.java.net/browse/JDK-8226514
>
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8226514/webrev.00/
Mainly looks good, just a few comments:
1) java/net/HttpURLConnection/SetAuthenticator/HTTPTest.java
Not sure why a switch is used here with a single non-default case. It
might be simpler to do something like
`if (authType != PROXY) return null; ...`
2) sun/net/www/http/HttpClient/RetryPost.java
sun/net/www/protocol/http/B6296310.java
Maybe allow the IOException to just propagate up ( without catching ) .
3) sun/net/www/protocol/http/B5017051.java
Maybe allow the IOException to just propagate up ( without catching ) .
Can we remove the loooong fully qualified name?
com.sun.net.httpserver.HttpServer
-Chris.
