Alex,
On 29/03/2019 22:07, Alex Menkov wrote:
(added net-dev as suggested by Alan)
Net gurus, please assist in reviewing socket-related code.
New webrev:
http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/
Specifically on SocketTransportService.java. What Arthur has
proposed is better ( changing to lastIndexOf alone is not
sufficient ). Or is your assumption that the IPv6 literal is
not enclosed in square brackets?
If keeping Arthur's `static class HostPort` please make the
fields final.
>> Would it make sense to support the preference properties?
>> java.net.preferIPv4Stack
>> java.net.preferIPv6Addresses
I'm not sure about this, especially given the property name
prefixes. I need to think a little more on it.
There is quite a bit of new native code, is it possible to
rewrite any of this in Java, e.g. reading of the system
properties ( if that is to remain )?
-Chris.
