On 11/12/2017 17:24, Martin Buchholz wrote:
There's now a Martin-style benchmark at
http://cr.openjdk.java.net/~martin/webrevs/jdk/URLMicroBenchmark/
<http://cr.openjdk.java.net/%7Emartin/webrevs/jdk/URLMicroBenchmark/>
that suggests the code is ~ 25% faster with default JVM flags (C2) but
~ 25% slower with C1, as you might expect with multiple String
concatenation. I think we want to optimize for the default and assume
that multiple String concatenation does in fact get optimized.
I'm not planning to check in the benchmark code.
Good to confirm the improvement, I think the change is good to push.
-Alan
