Hi Martin, I think the new code is more compact and readable which makes it nice. I reviewed it to check that the result is still the same as before. However, I can’t assess if it is acceptable from a performance point of view and would defer this assessment to some other reviewer. But apart from performance constraints the change seems good.
Best regards Christoph From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Martin Buchholz Sent: Dienstag, 5. Dezember 2017 05:01 To: net-dev <net-dev@openjdk.java.net> Subject: RFR: 8193034: Optimize URL.toExternalForm http://cr.openjdk.java.net/~martin/webrevs/jdk/URL.toExternalForm/