Hi Chris,
Looks good, nice use of streams.
B6558853.java: 28: an extra "*"
A few tests do nothing unless an interface is found; they could use
either output that says what
interface is tested or a message that no interface was available.
(In case someone is reviewing the logs and wants to know what was tested).
Roger
On 4/12/2017 9:56 AM, Chris Hegarty wrote:
This is a tests only change.
Several networking tests appear to fail intermittently on recent
Mac machines. In most cases an Apple Peer-to-Peer, awdl0,
interface, has been seen to be chosen by the test, for some
operation or other, when enumerating the set of network
interfaces on the machine. Such an interface may not be
suitable to perform the operation required by the test, and
thus best avoided.
http://cr.openjdk.java.net/~chegar/8177536.00/
<http://cr.openjdk.java.net/%7Echegar/8177536.00/>
This change attempts to create a NetworkConfiguration utility
class that can be expanded on to centralize the logic for most
networking related tests. For now, I’ve done the minimum
possible here to get the tests back to a reasonable shape, but
I expect that we can do further clean up and consolidation in the
future.
-Chris.
