Hi Sergei,
On 07/12/16 15:01, Chris Hegarty wrote:
On 7 Dec 2016, at 14:55, Sergei Kovalev <sergei.kova...@oracle.com> wrote:
Hi Team,
Please review a simple fix for networking test.
BugID: https://bugs.openjdk.java.net/browse/JDK-8170864
WebRev: http://cr.openjdk.java.net/~skovalev/8170864/webrev.00/
Issue: One of networking tests fails in case using a command line option
"--limit-module".
Root cause: there is undeclared dependency on java.logging.
Are you sure of this? The test does not use logging directly, and the HTTP
server no longer uses jdk.util.logging ( it uses the system logger ).
I agree with Chris that is strange. It's possible that loading
a java.sql class required logging to be present - I believe there's
a requires transitive java.logging in the sql module.
Now that you have removed that dependency it would be worth checking
whether java.logging is still required.
Also I am puzzled by:
28 * @library ../../../../com/sun/net/httpserver
I wonder what in this test requires anything from this
directory which is not a library and only contains httpserver
tests?
best regards,
-- daniel
