Sergei, > On 7 Dec 2016, at 14:55, Sergei Kovalev <sergei.kova...@oracle.com> wrote: > > Hi Team, > > Please review a simple fix for networking test. > > BugID: https://bugs.openjdk.java.net/browse/JDK-8170864 > WebRev: http://cr.openjdk.java.net/~skovalev/8170864/webrev.00/ > > Issue: One of networking tests fails in case using a command line option > "--limit-module". > Root cause: there is undeclared dependency on java.logging.
Are you sure of this? The test does not use logging directly, and the HTTP server no longer uses jdk.util.logging ( it uses the system logger ). > Solution: add dependency declaration into jtreg header. The benefit of > logging module usage already discussed in a review of similar CR (see: > http://mail.openjdk.java.net/pipermail/net-dev/2016-November/010422.html). > > Also the failing tests uses "java.sql.Array" class to demonstrate class > loading ability. There is two ways to resolve the issue: either add > dependency declaration on java.sql module or change the Array class by > something else. java.sql.Array class isn't important for the test logic and > could be easily replaced. It seemed useful to be able to run the test in as > many environment as possible. Therefore it is better to eliminate dependency > on java.sql module. I agree with this change. -Chris.
