Hi Daniel, I pushed it (http://hg.openjdk.java.net/jdk9/dev/jdk/rev/109f1765cc39) and I stepped back from annotating the serialization callback to keep consistency. Maybe it is something that rather Eclipse should fix...
Thanks & Best Christoph > -----Original Message----- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Montag, 1. August 2016 12:10 > To: Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net > Subject: Re: RFR (XS): 8162819: fix minor Javadoc issues and remove warnings > in java.net.Socket and java.net.Inet*Address > > Hi Christoph, > > On 01/08/16 10:43, Langer, Christoph wrote: > > Hi Daniel, > > > > the warning is shown by my Eclipse IDE, javac -Xlint does not warn about > unused methods, I think. > > > > So, then the tag @SuppressWarnings("unused") should probably not be used? > Or what's the official OpenJDK standard for this type of warnings? > > > > I have no strong opinion on this - but I don't think > any other readObject / serialization callback have been annotated > in the JDK. > > best regards, > > -- daniel
