Hi Daniel,
the warning is shown by my Eclipse IDE, javac -Xlint does not warn about unused
methods, I think.
So, then the tag @SuppressWarnings("unused") should probably not be used? Or
what's the official OpenJDK standard for this type of warnings?
Thanks
Christoph
> -----Original Message-----
> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com]
> Sent: Montag, 1. August 2016 10:32
> To: Langer, Christoph <christoph.lan...@sap.com>; net-dev@openjdk.java.net
> Subject: Re: RFR (XS): 8162819: fix minor Javadoc issues and remove warnings
> in java.net.Socket and java.net.Inet*Address
>
> On 31/07/16 22:47, Langer, Christoph wrote:
> > Hi,
> >
> >
> >
> > please review these small fixes for Javadoc issues and removal of warnings.
> >
> >
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8162819
> >
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8162819.1/
>
> Hi Christoph,
>
> The Javadoc changes look good to me.
> I'm surprised that @SuppressWarnings("unused") is needed for
> InetSocketAddress::readObjectNoData.
>
> best regards,
>
> -- daniel
>
> >
> >
> >
> > Thanks
> >
> > Christoph
> >
> >
> >
