On 13/08/2014 15:02, Claes Redestad wrote:
Hi,

can I have a review for this patch to take advantage of offset-based parseInt methods added in
8041972 for java.net/sun.net classes?

bug: https://bugs.openjdk.java.net/browse/JDK-8055032
webrev: http://cr.openjdk.java.net/~redestad/8055032/webrev.0

This causes fewer temporary String objects to be allocated and shows a direct throughput improvement in micros (1.2x in java.net.URLDecoder#decode and sun.net.www.ParseUtil#decode, for example)
These changes look okay to although the downside is that it's less readable in a few places.

Are there micro benchmarks being created as part of this work? If so, are they being pushed to a repository in OpenJDK for use by others?

-Alan

Reply via email to