On 15/05/13 19:22, Alan Bateman wrote:
On 15/05/2013 18:09, Chris Hegarty wrote:
The change looks fine to me.
-Chris
On 15 May 2013, at 17:33, Michael McMahon
<michael.x.mcma...@oracle.com <mailto:michael.x.mcma...@oracle.com>>
wrote:
This is the webrev for the bug
http://cr.openjdk.java.net/~michaelm/8012625/webrev.1/
Thanks
Michael
The fix looks okay to me too.
For the test then is there any reason that is has to run in othervm
mode? Just wondering if you could shutdown the http server when done.
Also not clear why the fields are static when they are initialized in
the ctor. Alignment issue at L93.
Probably doesn't need to be othervm, as it is cleaning up already. The
test was written quickly, hence
the static/instance field confusion. That can be changed easily too.
Thanks
Michael
-Alan.
