[I'm not sure mutt-users is the right place to talk about patches. I
will then answer briefly some points that might be of interest here, but
I'll address further discussions to the people interested in this patch.
Of course, anyone is welcome to participate, just mail me! :-) ]
> Ok, Cedric. Sorry it took me so long to get any feedback to you but
> here it is:
Thanks!
> I am using the latest mutt (1.3.21_2) port on FreeBSD 4.3 PreRelease.
> I took your patch file and broke it down into the attached patches to
> be dropped as is into the ports files directory along with the other
> patches. No other mods needed.
I don't know much about FreeBSD. Is this required for the ports to break
a patch into many little diffs?
> Anyway, I realize your patch was intended for 1.3.20, but I hadn't any
> opportunity to play with it until I convinced myself to upgrade mutt.
> But that's neither here nor there.
You'll find the updated patch for 1.3.21 here:
http://cedricduval.free.fr/mutt/
> Now for the details. It works great. Exactly as I expected. Except
> for one thing. It seems either function doesn't apply itself unless I
> also happen to be deleting another message in the same folder. If I do,
> everything comes up threaded as expected. Here is what I've done:
[...]
> I realize this may be because I applied a 1.3.20 patch to 1.3.21, and
> a clean patch and build can't guarantee clean behavior, but I thought
> this might at least help you get it ready for 1.3.21 more easily.
Might be... Are you sure the whole patch applied cleanly. Nothing
failed? Are the threads really not broken when you apply break-thread?
This might be a consequence of the $strict_threads option unset. If so,
Mutt might guess the threading if the subject has not changed...
Please try again with the 1.3.21 version of this patch.
> Thanks for the effort! I have followed all the 'main branch
> submission' controversy that has been flowing around, and personally,
> I'd like to see it set up as an available patch (especially for
> FreeBSD make options like I used above - hint hint to David O'Brien,
> who maintains the port :).
:-)
--
Cedric.
