On Sun, Sep 06, 2026 at 10:31:17AM +0200, Alejandro Colomar via Mutt-dev wrote:
Date: 2026-09-03 10:45:38+0800 From: "Kevin J. McCarthy" <[email protected]>Only check for multiple in-reply-to when there is more than one tagged message. Otherwise, why aren't we scanning the case where no message is tagged and we are replying to a single message?This part, LGTM. Thanks!
Thanks.
Add the same check to the recvattach menu too.Would you mind clarifying why it's being added in recvattach too?
It's the same action, but due to the completely different parent data structures, the recvattach menu has to re-implement parts of the reply.
Why were we not doing it before?
It being missing was basically a bug. The commit adding the check, f9ca2d43, added 17 years ago, forgot about the recvattach path and so left it out.
Should this be a separate patch with its own commit message justifying it?
I could split it into another commit, but as you can see, the code is basically the same, so it kind of makes sense to fix both at the same time (to me).
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
