On Sun, Jun 13, 2021 at 03:56:58PM +0200, Rene Kita wrote:
Using skip-quoted the first unquoted line becomes the new top line displayed in the pager. This leaves the user with no context to know what the answer refers to.
I need to get through a backlog of other things before I look too closely at this. However, I'd like others' opinions on the usefulness of the option. My initial impression is that it's not generally useful (i.e., if you need context then don't <skip-quoted>) but I'd appreciate others take.
Just glancing quickly, please watch the coding style. e.g.
while (test)
{
}
not
while (test){
}
+ while (!err && SkipQuotedContext > 0
It looks like the patch disables <skip-quoted> if $skip_quoted_context is left at 0?
+ if (new_topline - context < 0) + context += new_topline - context;
Could that just be:
if (context > new_topline)
context = new_topline;
Lastly, I'd prefer the config var have "pager_" in front to give it
context. (Pun intended). e.e. $pager_skip_quoted_context.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
