On Fri, Aug 21, 2020 at 10:31:42PM -0700, Will Yardley wrote:
Working on shellcheck first. I personally like doing them as separate steps, but let me know what you think:
Thanks for getting right on this, Will! Separate steps are fine with me too.
If anyone's an expert on shell portability, open to any suggestions / major concerns. I think that $() (vs. backticks) and "grep -E" should be POSIX compliant from what I've been able to dig up, but I know we have a conservative, and opinionated, audience here.
I commented in the MR too, but I'd prefer to keep the backticks for bourne shell compatibility. mkreldate.sh was briefly changed to use $() a couple years ago, and that broke bourne-shell based systems. So those are still apparently in use and I'd like to support them if possible. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
