On Fri, Aug 21, 2020 at 04:02:34PM -0700, Will Yardley wrote:
On Fri, Aug 21, 2020 at 03:25:12PM -0700, Kevin J. McCarthy wrote:Sorry for the delay. Applied.For some of these contrib scripts that are in languages like shell / Python / Perl / etc., would it be worth trying to setup some basic linting in CI?
Hi Will,That would be fine with me, *but* I'd rather the CI not fail because of a trivial linting issue. So "loose" as you mention below would be good.
I'm not super familiar with gitlab CI, though may be possible to do some things in there, and I think Travis and Circle are also typically free for open source. It might require some effort to unify the standards of certain scripts / programs, but might be worth the effort?
There is a .gitlab-ci.yml file in the Mutt source tree. The "build:" part is run after every push. You can see right now it just runs prepare and then make. We could just invoke the scripts directly there, but it would be better to have a make target, I think.
I wasn't sure if you were volunteering to dig into it, or just bringing the idea up. If the former, I would be happy to create the Makefile changes if you have suggestions on tools and their invocations.
The docker image config is stored in the repos at https://gitlab.com/muttmua/docker-images. So new dependencies can be added there and I'll regen and push up a new image as needed.
For shell, I have had really good luck with "shellcheck", and should be easy to get a flake8 / pylint config that's somewhat loose but still tightens things up a little?
Yes, that sounds like a good idea. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
