On Thu, Jun 28, 2018 at 9:15 PM Kevin J. McCarthy <ke...@8t8.us> wrote:
> On Tue, Jun 26, 2018 at 05:02:11PM -0700, Brandon Long wrote: > > Ok, this patch updates the current head to have > > (imap|pop|smtp)_oauth_refresh_command, consolidates the code for > executing > > the commands and generating the oauthbearer sasl token, and adds support > or > > oauthbearer for pop. > > Hi Brandon, I have two comments: > > 1) In mutt_account_getoauthbearer(), mutt_read_line() can return NULL, > so check for that too. > done 2) In the second patch: > > --- a/imap/auth_oauth.c > +++ b/imap/auth_oauth.c > @@ -50,7 +50,7 @@ imap_auth_res_t imap_auth_oauth (IMAP_DATA* idata, const > char* method) > > ilen = strlen (oauthbearer) + 30; > ibuf = safe_malloc (ilen); > - snprintf (ibuf, ilen, "AUTHENTICATE OAUTHBEARER %s", oauthbearer); > + snprintf (ibuf, ilen, "AUTHENTICATE OAUTHBEARER f%s", oauthbearer); Was the added "f" prefix intentional? > No, that was when I was testing my error handling, I thought I'd removed it. Brandon
mutt.patch-20180626.bl.imap-oauthbearer.2
Description: Binary data
