On Mon, Jun 11, 2018 at 5:22 PM Kevin J. McCarthy <ke...@8t8.us> wrote:
> On Mon, Jun 11, 2018 at 03:12:45PM -0700, Brandon Long wrote: > > Hey mutt-dev, long time no see. > > > > Gmail supports RFC 7628 for using OAUTH with IMAP, and they really don't > > like you using password based auth. You can still enable "less secure > > apps" and then generate an application specific password, but I figured > it > > was time to support it. > > Hi Brandon, > > Thank you for sending the patch. I will take a closer look in a few > days when I have a bit more time. Just after a quick look I have two > comments. > > It would be good to initialize ibuf[0] to '\0' before performing the > safe_strcat. > Will do. > Also, are you confident of the static buffer sizes? (I'm not familiar > with OAUTH specs, so I have no idea). A couple years ago I had to > change imap_auth_sasl to use dynamic sized buffer because even > HUGE_STRING wasn't big enough for someone [1cab7de7]. > I'm using 1024, which is definitely long enough for any existing implementations, but it does look like folks recommend against using fixed sizes. It's unfortunate that mutt doesn't have a dynamic string struct. Brandon
