On Fri, Jan 27, 2017 at 10:27:13AM -0800, Kevin J. McCarthy wrote: > On Fri, Jan 27, 2017 at 12:07:19PM +0000, Richard Russon wrote: > > > > Please find attached a patch against current Mutt tip to add LMDB > > > > > This was actually next on my list > > > I appreciate you bundling this up and sending it to the list! > > > > Would you consider *all* of our hcache changes? > > - LMDB > > - kyotocabinet > > - refactor to separate hcaches > > I'll certainly take a look. The current state of hcache at least begs > to be broken apart.
I took a brief look at the changes. In general, I like the idea. It's much cleaner than the mess that is the current hcache.c. Unfortunately, just in my brief perusal, I noticed this is not restrained to being a simple refactor. There are some behavior changes, at least one of which I believe is incorrect. When I have some more time, I think after 1.8, I may take another look. But changes that both move code around and modify/rewrite it have to be looked at pretty closely. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
