#3899: mutt_ssl's interactive_check_cert() has several issues
-----------------------+----------------------
Reporter: kevin8t8 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Component: crypto | Version:
Resolution: fixed | Keywords:
-----------------------+----------------------
Comment (by kevin8t8):
Hi Derek,
You eloquently voiced my reservations about the construct. It need not
only be a less-careful programmer that gets bit by this. I can imagine
refactoring a hunk of code out of a large function, turning the direct
array reference into a function parameter. It would be easy to miss the
problem.
However, I am reluctant to touch this function (interactive_check_cert)
any more. My original goal was to fix the X509_NAME_oneline() and
strstr() issues, which 1a2dc7b21b5b did.
At this point, I *am* willing to consider reverting 1196c859942e, if
others also voice a "nay" against the mutt_array_size() macro. So please
speak up if you have an opinion.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3899#comment:15>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
