#3899: mutt_ssl's interactive_check_cert() has several issues
-----------------------+----------------------
Reporter: kevin8t8 | Owner: mutt-dev
Type: defect | Status: closed
Priority: major | Milestone:
Component: crypto | Version:
Resolution: fixed | Keywords:
-----------------------+----------------------
Comment (by derekmartin):
FWIW, I think macros should be avoided, in general. They can cause too
many problems. They're OK for small bits of repetitive code in
performance-critical sections, but even then, you're usually better off
with an inline function instead.
Explicit is better than implicit. Macros make things more implicit, and
are hard to write in a way where they can always be used in place of an
equivalent expression or function call, resulting in ridiculous constructs
to make them sufficiently generalized. You should almost always just use
a function or write out the code instead, and limit macro usage to
eliminating the repeated use of hard-coded literal constants.
--
Ticket URL: <https://dev.mutt.org/trac/ticket/3899#comment:13>
Mutt <http://www.mutt.org/>
The Mutt mail user agent
