On Sat, Aug 13, 2016 at 01:20:47PM +0200, Vincent Lefevre wrote: > On 2016-08-12 07:32:00 -0700, Kevin J. McCarthy wrote: > > On Fri, Aug 12, 2016 at 08:09:00AM -0400, Aaron Schrab wrote: > > > At 12:31 -0700 08 Aug 2016, "Kevin J. McCarthy" <ke...@8t8.us> wrote: > > > > I'm going to push the second version of the patch. I don't think an > > > > uproar will ensue, but if so we can evaluate what to do. It's a small > > > > commit. > > > > > > I rebuilt my copy yesterday based on the tip at that time, and noticed a > > > bit > > > of a regression a little while ago. Previously using > > > <display-toggle-weed> > > > (default binding `h`) from the pager it would go back to the top of the > > > message, the position is now preserved. > > > > I'm pretty sure this patch didn't change this behavior, and that toggle > > headers has preserved position for quite a while (at least since > > 1.5.23). What version were you at before? > > I also notice this. So, I suppose that this comes from the patch.
I can confirm the behavior, but I can not confirm any regression. Again, I am seeing the same behavior in 1.6.0, 1.5.24, and 1.5.23: toggling the headers does *not* go back to the top of the message. Are you two absolutely sure you are seeing a behavior change? Perhaps I am misunderstanding. > I think that this should be fixed, as the goal of <display-toggle-weed> > is to see the headers (even though one could write a macro to do > <top>). While I think I agree, I am highly reluctant to change the behavior right now (during the freeze) unless there really is a regression. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
