On Thu, Jul 07, 2016 at 09:44:05AM -0700, Kevin J. McCarthy wrote:
> I'm also thinking about making a small change ...

Oh, you've already done it.  Too slow.
The patches look OK, and my quick tests work.

> > I've also seen a very short-lived display issue.

> This one is a bit scary.

A quick git bisect leads me to this commit: 594137a8ea12
    Add sidebar_format flag '%n' to display 'N' on new mail.

void draw_sidebar()
-    else if (b->msg_unread > 0)
+    else if ((b->msg_unread > 0) || (b->new))

> I'll be interested to hear more if you can replicate it.

Yes, but it's a little involved.

My mail's served by Dovecot over IMAP.  I have some Sieve rules
filtering incoming mail.  To reproduce the bug:

- clear header cache
- receive an email that gets marked as "seen" and put in a folder
  (that has no new mail)
- config: "color sidebar_new red default"

When I start Mutt the folder with the new, but "seen", mail is highlighted.
After $mail_check seconds, the highlight is cleared.
If I restart Mutt, I see the same highlight.

Next, if I open the mailbox, the highlight won't be seen again.
Unless, I clear the header cache and receive another email.

Your change to draw_sidebar() made this visible, but I'm not sure how
long this behaviour has been happening.

Rich

Attachment: signature.asc
Description: PGP signature

Reply via email to