On Thu, Jul 07, 2016 at 11:43:13AM +0100, Richard Russon wrote: > On Wed, Jul 06, 2016 at 06:13:07PM -0700, Kevin J. McCarthy wrote: > > Attached is a patch that I think should fix the problem. > > It's certainly a lot better. The "pages" seem stable now. > Also tested successfully: > Select first box on a page, then delete an earlier box > Select last box on a page, then add a new earlier box > Select first box on a page, then mark earlier box as read > Select last box on a page, then add new mail to earlier box
Thank you for the detailed testing. I will push the current patch a little bit later today after a bit more testing myself. > There's still a bug with page up/down when there are only hidden > mailboxes in that direction. e.g. Ah, that makes sense. It's easy enough to fix, I'll create a separate patch for that and post it here later today. I'm also thinking about making a small change in mutt_sb_notify_mailbox() for the "created" case. Right now we set HilIndex if it was unset, but I'm thinking of removing that and letting prepare_sidebar() set it instead (to help prevent the case where HilIndex points at a hidden mailbox that then becomes visible). Do you see a problem with that? > I've also seen a very short-lived display issue. When the Sidebar is > first drawn, the last mailbox is coloured as containing new mail. > This is corrected (immediately) on the next redraw. This one is a bit scary. While my change wasn't small, I tried to be pretty careful not to change the draw_sidebar logic much. I'll be interested to hear more if you can replicate it. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
