Hi Richard - I realize you're to some extent building your own extension/bundling of mutt here, which is fine. But a few comments since some discussion has already been had of whether these patches are mergeable:
* On 04 Apr 2016, Richard Russon wrote: > This release of NeoMutt contains no new features. > It's just a rebase of the code to Mutt-1.6.0. > > The current list of stable features is: > Conditional Dates Conditional Date Formatting +1. I've used this for many years, and support merge. > Fmemopen Use fmemopen(3) for speedier temporary files +0. Interesting; Linux-specific but looks like it's properly conditional. Would rather see this behavior merged with mutt_mktemp so it only happens once and we get the benefit everywhere. mutt_opentemp()? > Ifdef Conditional config options -0. Useful but an uncommon approach. Would sort of rather see mutt directly support abstract preprocessors so you can plug in m4, cpp, etc. > Index Color Theming of the Index List Curious how in-demand this is. > Initials Expando Expando for Author's Initials -0. My gut says this is a specific case of a broader abstraction that we might prefer to support instead (of using up another expando). Also, already done with reverse_alias and an alias. > Limit-Current-Thread Limit Index View to Current Thread -1. Would prefer a ~. that matches the current message; then a ~(~.) macro would be equivalent. > Nested If Deeply nested conditionals in format strings +0. I wrote this, and still use it. It does come with a caveat though: it changes the behavior of %<>. I would be very surprised if that affects many people, but it is a thing. > Notmuch Powerful email search engine No opinion. > Progress Bar Colourful Progress Bar Seems non-discrete in the github codebase. Not sure what this does. > Quasi-Delete Hide emails from view, but don't delete them Intriguing. Appears not to save on exit, but if it and there were a show-deleted or undelete option, I'd be pretty interested. > Sidebar Panel containing list of Mailboxes Still riddled with issues, last I heard, but I haven't looked at changes in a while. However if you really need to adjust screen drawing coordinates for everything, then the first issue is that it doesn't use distinct draw panels. > Skip-Quoted Skip Quoted Text Not sure whether this is best approach (it might be) but I like the basic idea. > Status Color Theming of the Status Bar Curious how in-demand this is too. > TLS-SNI Negotiate with a Server for a Certificate +0. Seems good, but haven't reviewed. > Trash Folder Move 'deleted' emails to a trash folder Overlaps functionally with quasi-delete. I sort of like quasi deletion more - it's like tag/labels vs folders. -- David Champion • d...@bikeshed.us
