tl;dr -- I want to to extensively tidy the mutt code
Mutt's great, but it's the work of hundreds of people over a couple of
decades and that *really* shows in the code.
The code desperately needs cleaning up and I'm keen to make those changes.
Tidy, well documented code, will:
make maintenance easier
encourage more people to contribute
make it easier to enforce stricter rules when accepting new code
The changes I'd like to make are strictly *non-functional*.
Whitespace:
trailing -- delete it
leading -- fix indent
embedded -- consistency around ()s, arithmetic, etc
alignment -- line up =, () to aid legibility
Braces:
consistency -- K&R, Linux kernel, GNU?
compulsory?
Misc:
#if 0 -- some are 16 years old
#ifdef / #if -- consistency
#includes -- check what's needed, ordering
static -- ~50 local functions aren't declared static
booleans -- ~750 occurrences of "return 0;" or "return 1;"
comments -- add to more functions
What about the patches?
I know there are many patches for mutt and changing the code will make
it harder for their maintainers, but there will never be a time where
there are no patches. There will never be a perfect time to tidy, but
still it needs to be done.
Questions...
Are you, the mutt community, willing to accept widespread changes?
Who decides on the style guidelines?
How quickly can we make the decisions, so I can get to work?
Cheers,
Rich Russon (flatcap)
