Hello!

acefael has written on Sunday,  3 May, at 12:06:

>the diff removes "puts (_(Copyright));"
>and it adds the loop wherein it calls "puts (_(Copyright[i]));".
>agreed?

    Mea culpa. I paid not enough attention to the diff, I'm sorry. Your
recent patch looks pretty much fine although if that was me then I would
rather not do calculations like sizeof(Copyright)/sizeof(Copyright[0])
but would do something like this:

static const char *Copyright[] = {
    N_(....),
    .....
    NULL
};

.....

    const char **c;
    for (c = Copyright; *c; c++)
        puts (_(*c));

That way it will not require any calculations at all. I'm sorry for the
intervention.

    With best regards,
    Andriy.

Reply via email to