Hi acefael,

On Saturday, 2015-05-02 13:32:23 +0100, acefael wrote:

> what do you think about the attached patch

Why send the mail twice? Anyway..

> [...]
> +"Many others not mentioned here contributed code, fixes," ,
> +"and suggestions." };
>  
> -      puts (_(Copyright));
> +      {
> +        int csize = sizeof(Copyright)/sizeof(Copyright[0]);
> +        int i;
> +        for( i = 0 ; i < csize ; ++i ) {
> +          puts (_(Copyright[i]));
> +        }
> +      }

What you may not be aware of, the _() underscore function is a special
function for the gettext() translation process. AFAIK it does not work
with array elements this way (someone correct me if I'm wrong). My
suggestion is, as the actual copyright information and names are not to
be translated, hold them in an array like you introduced, but do not use
_() on the elements, and only for the final sentence "Many others..."
use a separate variable and use that in _().

  Eike

-- 
OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
Use LibreOffice! https://www.libreoffice.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to