#3743: Performance regression with 'color index' command in mutt 1.5.22 -----------------------+---------------------- Reporter: sforshee | Owner: mutt-dev Type: defect | Status: new Priority: major | Milestone: Component: mutt | Version: 1.5.22 Resolution: | Keywords: -----------------------+----------------------
Comment (by kevin8t8): The problem with this patch is that it moves the mime_lookup checks after the AutoViewList scan. The mime_lookup needs to run first so it can potentially modify the mime type using the extension. Perhaps a mutt_check_lookup_list() call could be added just before the AutoViewList for-loop scan? It would be run again by the rfc1524_mailcap_lookup() but I don't think that's too big a deal. It might also be worth adding a comment somewhere in there mentioning the performance regression (and thus why the rfc1524_mailcap_lookup() is run last). Also, I'm not really familiar with this part of the code yet, so it would be good for a more experienced committer to take a look at the revised patch too. -- Ticket URL: <http://dev.mutt.org/trac/ticket/3743#comment:1> Mutt <http://www.mutt.org/> The Mutt mail user agent