On 2012-12-18 at 14:06 -0800, Michael Elkins wrote: > My current plan is to ensure that all the bugfixes that are > applied to the mutt packages in various OS distributions have been > rolled into the hg repo, then push out a 1.5.22 release. > > I've found the patches from some distros here: > > Fedora: http://pkgs.fedoraproject.org/cgit/mutt.git/tree/?h=f18 > Debian: > http://anonscm.debian.org/gitweb/?p=pkg-mutt/mutt.git;a=tree;f=debian/patches;h=001cba693d8880724697043c10d833be9e4db387;hb=master > > I would appreciate some feedback either from the maintainers/users of > other distros to make sure I'm not missing any important bugs.
FreeBSD: * http://svnweb.freebsd.org/ports/head/mail/mutt/files/ > Note that right now I am focusing just on bugfixes, not feature > patches, so that a new release can be created soon. Files matching glob extra-patch-* are feature patches and not covered below. Files matching glob patch-* are automatically applied always. You should probably look at: patch-bdb patch-contrib-Makefile.am patch-imap-message.c patch-nbsp patch-pgp In detail: * patch-02 : packaging; looks ignorable make/html changes; use lynx not elinks * patch-05 : feature / old-behaviour-restoration something with y/n responses and prompts * patch-08 : default Muttrc change "set followup_to=no" * patch-Makefile.am : packaging; looks ignorable mime.types do not install by default * patch-Makefile.am.doc : packaging; might be useful "Do not format manual during installation" Changes SUBDIRS definition ordering, moves doc/ to after ./ Haven't investigated context, might make sure format is done during build, not install? * patch-bdb : ** useful, update BDB_VERSIONS Adds a bunch of versions to BDB_VERSIONS * patch-color-eol : feature Adds "color_after_eol" option * patch-configure.ac : packaging? Removes ANSI-compliance check 'AM_C_PROTOTYPES' * patch-contrib-Makefile.am : ** useful? Updates SAMPLES definition * patch-crypt-gpgme.c : ignore, backport of in-tree fix d626fb87c489 fix, minimalised actual logic * patch-date-conditional : feature dgc.deepif.1 patch-1.5.0.ats.date_conditional.1 * patch-doc-manual.xml.head : ignore, packaging switches a DTD to use local path instead of public URL * patch-examples : ignore, packaging Moves examples installation location * patch-gnutls-CN-validation : CVE-2011-1429 fix I strongly suspect this is already in-tree * patch-imap-message.c : ** might be needed http://bugs.mutt.org/3288 The fix confirms that a pointer is not NULL, and is not in current source (but might have been fixed differently?) * patch-init.c : OS-specific, ignorable uses gethostname() instead of uname() on ancient FreeBSD FreeBSD pre 5.0 isn't supported, I'm surprised this patch is still there * patch-mktemp : probably ignorable Use mktemp() with templated filenames instead of the fixed pattern in mutt; technically correct, I'm guessing mutt does what it does for portability * patch-nbsp : ** feature / charset bug-correction, might want Handle non-breaking whitespace in UTF-8 mode * patch-pgp : ** fixes \r\n in PGP-handling The fix looks like something needed, but the approach taken is brute-force * patch-smime-self : feature, "smime_encrypt_self" option * patch-smime-sender : feature, "smime_dont_check_sender" option * patch-threadcomplete : feature Adds 'a' flag to pattern searches, wraps match_threadcomplete() Regards, -Phil
