On Fri, Dec 14, 2012 at 05:37:31PM -0600, David Champion wrote:
Questions about subject replacement have come up twice recently in
mutt-users, and Michael has expressed support for the principle, so I'm
resending this patch to the -dev list for review.
Patch 1: refactors the regex replacement used by spam matching into a
more abstract replacement mechanism, REPLACE_LIST
Patch 2: adds subject replacement based on the new REPLACE_LIST type
Patch 3: adds mailbox name replacement
Documentation is now included, new since previous patch versions.
So in general this is pretty cool--I was thinking of something
much simpler, but the ability to expand submatches is kind of
neat.
I think my only issue is an aesthetic one--the subjectrx and
mailboxrx keywords are not really descriptive enough. Elsewhere
in the configuration language, we tend to call these things
"*-hook".
Actually, now that I'm looking at the hook code, it seems there is
a lot of duplication with the existing SpamList support. I'm not
sure why that wasn't written using the support functions in hook.c
as well.
me
